fix(rosetta): rosetta reader expects default tablet file to be uncompressed #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizencc
commented
Aug 25, 2022
| @@ -148,7 +147,7 @@ export class RosettaTabletReader { | |||
| * pacmak sends our way later on is not going to be enough to do that. | |||
| */ | |||
| public async addAssembly(assembly: spec.Assembly, assemblyDir: string) { | |||
| const defaultTablet = path.join(assemblyDir, DEFAULT_TABLET_NAME); | |||
| const defaultTablet = guessTabletLocation(assemblyDir); | |||
There was a problem hiding this comment.
argh. This is the bug that I've been searching for.
kaizencc
changed the title
kaizencc
changed the title
RomainMuller
approved these changes
Aug 26, 2022
madeline-k
approved these changes
Aug 26, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in
rosetta-reader.ts, we always expect to find the implicit tablet at.jsii.tabl.json. This means that any compressed implicit tablets will be unable to be used as a cache, and causes the following failure:The following snippet was not found in any of the loaded tablets: ...This PR also slightly changes the default behavior of
compressTablet; previously it wasfalseby default. Now it respects the original compression status of the implicit tablet, i.e. if it was previously compressed, thenextractwill update it as compressed.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.