fix(rosetta): flakey trim-cache test #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears the trim-cache test using tablet compression occasionally fails in CI/CD. I suspect this is due to the `save` function returning before the GZip stream has bene closed, resulting in the subsequent read attempting to consume an incomplete GZip object. This adds the necessary provisions to ensure the GZip stream is closed (or failed) before `save` returns.
rix0rrr
approved these changes
Apr 5, 2023
aws-cdk-automation
pushed a commit
to aws/jsii-rosetta
that referenced
this pull request
Apr 5, 2023
It appears the trim-cache test using tablet compression occasionally fails in CI/CD. I suspect this is due to the `save` function returning before the GZip stream has bene closed, resulting in the subsequent read attempting to consume an incomplete GZip object. This adds the necessary provisions to ensure the GZip stream is closed (or failed) before `save` returns. Forward-ported from aws/jsii#4043 --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
RomainMuller
removed
the
pr/do-not-merge
RomainMuller
added a commit
to aws/jsii-rosetta
that referenced
this pull request
Apr 5, 2023
It appears the trim-cache test using tablet compression occasionally fails in CI/CD. I suspect this is due to the `save` function returning before the GZip stream has bene closed, resulting in the subsequent read attempting to consume an incomplete GZip object. This adds the necessary provisions to ensure the GZip stream is closed (or failed) before `save` returns. Forward-ported from aws/jsii#4043 --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears the trim-cache test using tablet compression occasionally fails in CI/CD. I suspect this is due to the
savefunction returning before the GZip stream has bene closed, resulting in the subsequent read attempting to consume an incomplete GZip object.This adds the necessary provisions to ensure the GZip stream is closed (or failed) before
savereturns.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.