fix(pacmak): _ is not treated as a keyword in Java #4094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Java 9, `_` is considered a keyword. Although we are technically still targeting Java 8 with our source, if we want our source to be parseable by more modern tools or are considering raising the threshold at some point, it would be good to have this in place already. This might technically be considered breaking in case someone is using `_` as an identifier in a public API, since in newer releases it will be renamed. But given that most jsii library authors will be targeting users that will be running on recent Java versions, and Java 9 is ~6 years old, the chance of that happening in practice is vanishingly small.
RomainMuller
approved these changes
May 15, 2023
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Java 9,
_is considered a keyword. Although we are technicallystill targeting Java 8 with our source, if we want our source to
be parseable by more modern tools or are considering raising the
threshold at some point, it would be good to have this in place already.
This might technically be considered breaking in case someone is
using
_as an identifier in a public API, since in newer releasesit will be renamed. But given that most jsii library authors will be
targeting users that will be running on recent Java versions, and Java 9
is ~6 years old, the chance of that happening in practice is vanishingly
small.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.