Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsii-pacmak): disable doclint #4103

Merged
merged 2 commits into from
May 15, 2023
Merged

fix(jsii-pacmak): disable doclint #4103

merged 2 commits into from
May 15, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented May 15, 2023

Our generated javadocs have some problems (PRs are out to fix them). We need to disable doclint otherwise proper error messages and doc failures get lost between the linting errors.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Our generated javadocs have some problems (PRs are out to fix them).
We need to disable `doclint` otherwise proper error messages and
doc failures get lost between the linting errors.
@rix0rrr rix0rrr requested a review from a team May 15, 2023 11:58
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 15, 2023
@mergify
Copy link
Contributor

mergify bot commented May 15, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label May 15, 2023
@mergify
Copy link
Contributor

mergify bot commented May 15, 2023

Merging (with squash)...

@mergify mergify bot merged commit 30afa09 into main May 15, 2023
29 checks passed
@mergify mergify bot deleted the huijbers/no-doclint branch May 15, 2023 18:14
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants