Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): type object 'InterfaceDynamicProxy' has no attribute '__jsii_type__' #4209

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Aug 3, 2023

In the odd case where an opaque reference is returned (FQN is Object) and no interfaces are registered, the InterfaceDynamicProxy instance created to represent the value in Python did not have any delegate, resulting it in not having any visible properties; including a __jsii_type__ value on the __class__, or the __jsii_ref__ property, both of which are required for the vlaue to be able to correctly make it back to JavaScript.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…jsii_type__'

In the odd case where an opaque reference is returned (FQN is `Object`)
and no interfaces are registered, the `InterfaceDynamicProxy` instance
created to represent the value in Python did not have any delegate,
resulting it in not having any visible properties; including a
`__jsii_type__` value on the `__class__`, or the `__jsii_ref__` property,
both of which are required for the vlaue to be able to correctly make it
back to JavaScript.
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 3, 2023
@RomainMuller RomainMuller changed the title fix(python): type object 'InterfaceDynamicProxy' has no attribute '__… fix(python): type object 'InterfaceDynamicProxy' has no attribute '__jsii_type__' Aug 3, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Aug 3, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2023

Merging (with squash)...

@mergify mergify bot merged commit 057b267 into main Aug 3, 2023
40 checks passed
@mergify mergify bot deleted the rmuller/empty-proxy branch August 3, 2023 18:07
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants