feat(pacmak): support adding a suffix to Java package version #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows setting a `jsii.targets.java.maven.versionSuffix` key that defines a string to be appended at the end of the version number of the Maven package. If the suffix starts with `.` or `-`, it will be appended to the version number directly (`0.12.0` with suffix `.dp` will render `0.12.0.dp`); but otherwise, it'll be prepended with a `-` before it is concatenated with the version number (`0.12.0` with suffix `dp` will render `0.12.0-dp`).
ghost
requested a review
from 
eladb
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting a
jsii.targets.java.maven.versionSuffixkey thatdefines a string to be appended at the end of the version number of the
Maven package. If the suffix starts with
.or-, it will be appendedto the version number directly (
0.12.0with suffix.dpwill render0.12.0.dp); but otherwise, it'll be prepended with a-before it isconcatenated with the version number (
0.12.0with suffixdpwillrender
0.12.0-dp).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.