fix(dotnet): use fully-qualified type names #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop generating `using` statements for types referenced in a particular file, so as to avoid running into cases where a given type (leaf) name corresponds to a locally defined type as well as a dependent type, which breaks compilation as `dotnet` will resolve to the local type with higher priority than the `using` type. Fixes #650
eladb
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop generating
usingstatements for types referenced in a particularfile, so as to avoid running into cases where a given type (leaf) name
corresponds to a locally defined type as well as a dependent type, which
breaks compilation as
dotnetwill resolve to the local type withhigher priority than the
usingtype.Fixes #650
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.