feat: configure engines with node >= 10.3.0
#795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
requested review from
bmaizels,
garnaat and
a team
as code owners
As `node 8` is becoming EOL soon, we're upgrading the baseline `node` version requirement from `>= 8.10.0` to `>= 10.0.0`. At this point, the code generation is not affected, but this our first signal to consumers that they need to upgrade their runtimes and/or codebases. Additionally, normalized the order of fields in the `package.json` files to make it nicer for people to work in the mono-repo. Related to #794
RomainMuller
force-pushed
the
rmuller/node-10.0.0
branch
from
0ddd7ab
to
8022243
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
RomainMuller
added
the
pr/do-not-merge
|
It's possible the minimal version will need to be something higher (I think Edit: confirmed, should be |
RomainMuller
removed
the
pr/do-not-merge
RomainMuller
changed the title
engines with node >= 10.0.0engines with node >= 10.3.0
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
approved these changes
Sep 19, 2019
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
node 8is becoming EOL soon, we're upgrading the baselinenodeversion requirement from
>= 8.10.0to>= 10.3.0. At this point, thecode generation is not affected, but this our first signal to consumers
that they need to upgrade their runtimes and/or codebases.
Additionally, normalized the order of fields in the
package.jsonfilesto make it nicer for people to work in the mono-repo.
Related to #794
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.