fix(python): clear error message when trying to serialize function #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common error seems to be to try to pass a function as a parameter into a JSII call (have seen 3 occurrences of this in the last week). Previously, this call would fail when trying to assing the `__jsii_type__` property to the function object. Specifically catch this case to give a helpful error message. Fixes aws/aws-cdk#4064.
RomainMuller
approved these changes
Sep 26, 2019
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common error seems to be to try to pass a function as a parameter
into a JSII call (have seen 3 occurrences of this in the last week).
Previously, this call would fail when trying to assing the
__jsii_type__property to the function object.Specifically catch this case to give a helpful error message.
Fixes aws/aws-cdk#4064.
Related to #806
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.