fix: add more visibility for when we can't consolidate #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzneal
force-pushed
the
improve-consolidation-visibility
branch
from
23c41a2
to
c9038a5
Compare
tzneal
force-pushed
the
improve-consolidation-visibility
branch
from
c9038a5
to
2631fef
Compare
Pull Request Test Coverage Report for Build 4690194224
💛 - Coveralls |
jonathan-innis
approved these changes
Apr 13, 2023
jonathan-innis
pushed a commit
to jonathan-innis/karpenter
that referenced
this pull request
Apr 14, 2023
njtran
pushed a commit
to njtran/karpenter
that referenced
this pull request
May 3, 2023
njtran
added a commit
that referenced
this pull request
May 4, 2023
* chore: cleanup deprovisioning types * add inc * fix: add more visibility for when we can't consolidate (#292) * feat: Machine Migration (#273) * Revert "Revert machine migration changes (#176) (#241)" This reverts commit 9973eac. * Change owner reference to blockOwnerDeletion * Remove string logging for machine launch * Removing FailedInit since machine statusCondition captures it * Updated eventing on machines * action const * testfix * testfix2 * comments * rename * last * enum * fixcompile * export * fixredundancy * fixlogic * comment * renameVar --------- Co-authored-by: Todd Neal <tnealt@amazon.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aws/karpenter-provider-aws#3746
Description
Makes the inability to schedule all pods message more informative.
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.