Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix panic on tests that don't schedule to nodes #316

Conversation

jonathan-innis
Copy link
Member

Fixes #

Description

Fix a panic on testing that failed to schedule pods to a Machine/Node combination. We should return back a nil Machine if we fail to schedule and pass that back up so that we don't do any binding of that pod to the Machine/Node.

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner May 2, 2023 23:05
@jonathan-innis jonathan-innis force-pushed the fix-failed-scheduling-testing branch from add2b28 to 399f17f Compare May 2, 2023 23:09
@jonathan-innis jonathan-innis enabled auto-merge (squash) May 2, 2023 23:12
@coveralls
Copy link

coveralls commented May 2, 2023

Pull Request Test Coverage Report for Build 4866606697

  • 5 of 8 (62.5%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 81.905%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/test/expectations/expectations.go 5 8 62.5%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/node/controller.go 7 70.59%
Totals Coverage Status
Change from base Build 4866344853: 0.09%
Covered Lines: 6826
Relevant Lines: 8334

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 33435cd into kubernetes-sigs:main May 3, 2023
@jonathan-innis jonathan-innis deleted the fix-failed-scheduling-testing branch May 3, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants