Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce or eliminate use of null when updating tree structure #104

Closed
jotok opened this issue Dec 18, 2020 · 1 comment
Closed

Reduce or eliminate use of null when updating tree structure #104

jotok opened this issue Dec 18, 2020 · 1 comment

Comments

@jotok
Copy link
Collaborator

jotok commented Dec 18, 2020

In the original pointer based tree implementation, we used null values to indicate the absence of a parent or sibling node. In the new compact implementation, we use int and short indexes instead of pointers, and we define a constant NULL to indicate absence. Mixing null and NULL makes code hard to follow and maintain.

This task is to follow up on #103 to improve code maintainability by reducing or eliminating the use of null when updating tree states.

@jotok jotok added this to To do in Random Cut Forest v2 via automation Dec 18, 2020
@jotok jotok mentioned this issue Dec 18, 2020
@jotok
Copy link
Collaborator Author

jotok commented Jan 28, 2021

Closed by #122 .

@jotok jotok closed this as completed Jan 28, 2021
Random Cut Forest v2 automation moved this from To do to Done Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant