You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using certain callbacks, we force wakers to be set on the connection even if no async polling is happening. This is a confusing customer experience, as customers reasonably expect that they shouldn't need to set wakers if they aren't using any async functionality.
At a high level, we should check if the future is None before attempting to retrieve the waker. That way the waker is only required when it is actually used.
Requirements / Acceptance Criteria:
Customer's that aren't using async functionality should not need to set a waker on the connection.
The text was updated successfully, but these errors were encountered:
Problem:
When using certain callbacks, we force
wakers
to be set on the connection even if no async polling is happening. This is a confusing customer experience, as customers reasonably expect that they shouldn't need to set wakers if they aren't using any async functionality.See further discussion in #4596 (comment)
Solution:
At a high level, we should check if the future is
None
before attempting to retrieve the waker. That way the waker is only required when it is actually used.Requirements / Acceptance Criteria:
Customer's that aren't using async functionality should not need to set a waker on the connection.
The text was updated successfully, but these errors were encountered: