Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings/s2n-tls: wakers always required, even when async not used #4608

Open
jmayclin opened this issue Jun 14, 2024 · 0 comments
Open

bindings/s2n-tls: wakers always required, even when async not used #4608

jmayclin opened this issue Jun 14, 2024 · 0 comments

Comments

@jmayclin
Copy link
Contributor

Problem:

When using certain callbacks, we force wakers to be set on the connection even if no async polling is happening. This is a confusing customer experience, as customers reasonably expect that they shouldn't need to set wakers if they aren't using any async functionality.

See further discussion in #4596 (comment)

Solution:

At a high level, we should check if the future is None before attempting to retrieve the waker. That way the waker is only required when it is actually used.

Requirements / Acceptance Criteria:

Customer's that aren't using async functionality should not need to set a waker on the connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants