-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config parsing can be improved #16
Comments
thanks for the suggestion! |
+1 Currently it seems like only these 4 variables are able to be configured. Having the ability to define your own config.properties would be nice ( |
For users less keen on updating config files, it would also be nice if these custom config values could be passed to |
+1 |
I come from here also looking to configure the |
https://github.com/aws/sagemaker-inference-toolkit/blob/master/src/sagemaker_inference/model_server.py#L42
This code here can be improved to add a config file, and not just use the mms default or env vars that are parsed.
The utils can include support to merge/override config files, instead of appending string values to write to file.
The text was updated successfully, but these errors were encountered: