Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the socket path configurable #12

Closed
aramase opened this issue May 11, 2021 · 3 comments
Closed

Make the socket path configurable #12

aramase opened this issue May 11, 2021 · 3 comments

Comments

@aramase
Copy link
Contributor

aramase commented May 11, 2021

The socket endpoint is hardcoded and should be made configurable

secrets-store-csi-driver-provider-aws/main.go

Line 28 in 01138ad

endpoint := "/etc/kubernetes/secrets-store-csi-providers/aws.sock"

Closed
@vito-laurenza-zocdoc
Copy link

For reference, the csi driver provides a flag to configure the directory.

@joebaro
Copy link
Contributor

joebaro commented May 24, 2021

Thank you for opening this issue - we are looking into it.

@tam7t tam7t mentioned this issue May 28, 2021
Merged
@joebaro joebaro mentioned this issue Jun 4, 2021
Merged
@joebaro
Copy link
Contributor

joebaro commented Jun 4, 2021

Done in in PR 23 and PR 24

@joebaro joebaro closed this as completed Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joebaro @aramase @vito-laurenza-zocdoc