-
Notifications
You must be signed in to change notification settings - Fork 2.4k
/
test_logical_id_generator.py
195 lines (142 loc) · 7.23 KB
/
test_logical_id_generator.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
import hashlib
import json
from unittest import TestCase
from unittest.mock import patch
from samtranslator.translator.logical_id_generator import LogicalIdGenerator
class TestLogicalIdGenerator(TestCase):
"""
Test the implementation of LogicalIDGenerator
"""
def setUp(self):
self.prefix = "prefix"
@patch.object(LogicalIdGenerator, "_stringify")
def test_gen_no_data(self, stringify_mock):
generator = LogicalIdGenerator(self.prefix)
self.assertEqual(self.prefix, generator.gen())
# Calling gen() again should return the same result
self.assertEqual(generator.gen(), generator.gen())
stringify_mock.assert_not_called()
@patch.object(LogicalIdGenerator, "get_hash")
@patch.object(LogicalIdGenerator, "_stringify")
def test_gen_dict_data(self, stringify_mock, get_hash_mock):
data = {"foo": "bar"}
stringified_data = "stringified data"
hash_value = "some hash value"
get_hash_mock.return_value = hash_value
stringify_mock.return_value = stringified_data
generator = LogicalIdGenerator(self.prefix, data_obj=data)
expected = "{}{}".format(self.prefix, hash_value)
self.assertEqual(expected, generator.gen())
get_hash_mock.assert_called_once_with()
stringify_mock.assert_called_once_with(data)
self.assertEqual(generator.gen(), generator.gen())
@patch.object(LogicalIdGenerator, "_stringify")
def test_gen_hash_data_override(self, stringify_mock):
data = {"foo": "bar"}
stringified_data = "stringified data"
hash_value = "6b86b273ff"
stringify_mock.return_value = stringified_data
generator = LogicalIdGenerator(self.prefix, data_obj=data, data_hash=hash_value)
expected = "{}{}".format(self.prefix, hash_value)
self.assertEqual(expected, generator.gen())
stringify_mock.assert_called_once_with(data)
self.assertEqual(generator.gen(), generator.gen())
@patch.object(LogicalIdGenerator, "_stringify")
def test_gen_hash_data_empty(self, stringify_mock):
data = {"foo": "bar"}
stringified_data = "stringified data"
hash_value = ""
stringify_mock.return_value = stringified_data
generator = LogicalIdGenerator(self.prefix, data_obj=data, data_hash=hash_value)
stringify_mock.assert_called_once_with(data)
self.assertEqual(generator.gen(), generator.gen())
def test_gen_stability_with_copy(self):
data = {"foo": "bar", "a": "b"}
generator = LogicalIdGenerator(self.prefix, data_obj=data)
old = generator.gen()
new = LogicalIdGenerator(self.prefix, data_obj=data.copy()).gen() # Create a copy of data obj
self.assertEqual(old, new)
def test_gen_stability_with_different_dict_ordering(self):
data = {"foo": "bar", "nested": {"a": "b", "c": "d"}}
data_other = {"nested": {"c": "d", "a": "b"}, "foo": "bar"} # Same content but different ordering of keys
generator = LogicalIdGenerator(self.prefix, data_obj=data)
old = generator.gen()
new = LogicalIdGenerator(self.prefix, data_obj=data_other).gen()
self.assertEqual(old, new)
def test_gen_changes_on_different_dict_data(self):
data = {"foo": "bar", "nested": {"a": "b", "c": "d"}}
data_other = {"foo2": "bar", "nested": {"a": "b", "c": "d"}} # Just changing one key
old = LogicalIdGenerator(self.prefix, data_obj=data)
new = LogicalIdGenerator(self.prefix, data_obj=data_other).gen()
self.assertNotEqual(old, new)
def test_gen_changes_on_different_string_data(self):
data = "some data"
data_other = "some other data"
old = LogicalIdGenerator(self.prefix, data_obj=data)
new = LogicalIdGenerator(self.prefix, data_obj=data_other).gen()
self.assertNotEqual(old, new)
@patch.object(LogicalIdGenerator, "get_hash")
@patch.object(LogicalIdGenerator, "_stringify")
def test_error_stringifying(self, stringify_mock, get_hash_mock):
data = {"foo": "bar"}
hash_value = "some hash value"
get_hash_mock.return_value = hash_value
stringify_mock.side_effect = TypeError("error")
with self.assertRaises(TypeError):
LogicalIdGenerator(self.prefix, data_obj=data)
get_hash_mock.assert_not_called()
@patch.object(LogicalIdGenerator, "_stringify")
def testget_hash(self, stringify_mock):
data = "some data"
stringified_data = "some stringified data"
stringify_mock.return_value = stringified_data
generator = LogicalIdGenerator(self.prefix, data_obj=data)
# We are essentially duplicating the implementation here. This is done on purpose to prevent
# accidental change of the algorithm. Any changes to the hash generation must be backwards compatible.
# This test will help catch such issues before hand.
utf_data = str(stringified_data).encode("utf8")
expected = hashlib.sha1(bytes(utf_data)).hexdigest()[:10]
self.assertEqual(expected, generator.get_hash())
stringify_mock.assert_called_once_with(data)
@patch.object(LogicalIdGenerator, "_stringify")
def testget_hash_no_data(self, stringify_mock):
data = "some data"
stringified_data = None
stringify_mock.return_value = stringified_data
generator = LogicalIdGenerator(self.prefix, data_obj=data)
self.assertEqual("", generator.get_hash())
stringify_mock.assert_called_once_with(data)
def test_stringify_basic_objects(self):
data = {"a": "b", "c": [4, 3, 1]}
expected = '{"a":"b","c":[4,3,1]}'
generator = LogicalIdGenerator(self.prefix, data_obj=data)
self.assertEqual(expected, generator._stringify(data))
def test_stringify_basic_objects_sorting(self):
data = {"c": [4, 3, 1], "a": "b"}
expected = '{"a":"b","c":[4,3,1]}'
generator = LogicalIdGenerator(self.prefix, data_obj=data)
self.assertEqual(expected, generator._stringify(data))
def test_stringify_array_sorting(self):
data = ["a", 1, {"z": "x", "b": "d"}]
expected = '["a",1,{"b":"d","z":"x"}]'
generator = LogicalIdGenerator(self.prefix, data_obj=data)
self.assertEqual(expected, generator._stringify(data))
def test_stringify_strings(self):
data = "some data"
generator = LogicalIdGenerator(self.prefix, data_obj=data)
# Strings should be returned unmodified ie. json dump is short circuited
self.assertEqual(data, generator._stringify(data))
@patch.object(json, "dumps")
def test_stringify_expectations(self, json_dumps_mock):
data = ["foo"]
expected = "bar"
json_dumps_mock.return_value = expected
generator = LogicalIdGenerator(self.prefix, data_obj=data)
self.assertEqual(expected, generator._stringify(data))
json_dumps_mock.assert_called_with(data, separators=(",", ":"), sort_keys=True)
@patch.object(json, "dumps")
def test_stringify_expectations_for_string(self, json_dumps_mock):
data = "foo"
generator = LogicalIdGenerator(self.prefix, data_obj=data)
self.assertEqual(data, generator._stringify(data))
json_dumps_mock.assert_not_called()