This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
elasticsearch 2.x support #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new pom.xml.elasticsearch-2.0.0 example for building with elasticsearch 2.0.0 (tested on 2.0.0 and 2.0.1 so far). And added a new Elasticsearch2Emitter.java that contains all the needed changes to make this library work with elasticsearch 2.x.x. //TODO - The changes in Elasticsearch2Emitter.java need to be merged into ElasticsearchEmitter.java and the imort of "import org.elasticsearch.common.settings.ImmutableSettings;" needs to be driven by the version of elasticsearch used, the "ElasticsearchEmitter" function also needs to be dependent on the version.
Added support for elasticsearch 2.x.x
This was referenced Jan 21, 2016
|
Any update on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently there is no elasticsearch 2.x.x support in the
amazon-kinesis-connectorslibrary. This PR is a first step forward towards getting support implemented.Status
WORK IN PROGRESS / NEED HELP
Related Issues and PRs
Background
I was enticed to use the cloudwatch-logs-subscription-consumer by @dvassallo one day and went about trying to get it to work with our already implemented elasticsearch 2.0.0 installation in AWS. By figuring out what had changed between the 1.x and 2.x versions of elasticsearch (great reference here) I was then able to go through the
amazon-kinesis-connectorscode and thecloudwatch-subscription-consumercode and make some changes to support 2.x. I then built a local.jarforamazon-kinesis-connectorsafter making somepom.xmlchanges. Followed by changes tocloudwatch-logs-subscription-consumerthat fixedImmutableSettingsand re-wrote theElasticsearchEmitterfunction to use the methods outlined in the java api doc here.I was then able to make a successful connection to elasticsearch and see records start coming through. There are still a few things to iron out, they are outlined below. But the hope is, people who really need it can start using the configs in the PR and then soon it will be merged and fully functional.
ToDos
ElasticsearchEmitterneeds to be able to determine the elasticsearch version it is using from thepom.xml, and then use the correct imports and function syntax. I am a newbie to Maven, and not a Java expert so this is beyond me for now.Other Notes