Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit App APIs #1891

Closed
eladb opened this issue Feb 26, 2019 · 0 comments · Fixed by #2731 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Closed
Assignees
Labels
@aws-cdk/core Related to core CDK functionality

Comments

@eladb
Copy link
Contributor

eladb commented Feb 26, 2019

Most of the synthesizeStack and synthesizeStacks are there mostly for testing purposes and legacy. We should probably revisit.

Remove legacy and clean up so we don't have to break in the future.

@eladb eladb added the @aws-cdk/core Related to core CDK functionality label Feb 26, 2019
@eladb eladb removed the package/awscl Cross-cutting issues related to the AWS Construct Library label May 1, 2019
@rix0rrr rix0rrr self-assigned this May 29, 2019
eladb pushed a commit that referenced this issue Jun 3, 2019
Ensure documentation coverage and clean up of the various APIs.

Fixes #1891


BREAKING CHANGE:
* **core:** `StackProps.autoDeploy` has been removed and replaced by `StackProps.hide` (with negated logic).
* **core:** `ISynthesizable.synthesize` now accepts an `ISynthesisSession` which contains the `CloudAssemblyBuilder` object.
* **cx-api:** Multiple changes to the cloud assembly APIs to reduce surface area and clean up.
eladb pushed a commit that referenced this issue Jun 5, 2019
Fixes #1891

Testing: all toolkit integration tests passed.

BREAKING CHANGE:

* **cli:** This release requires CDK CLI >= 0.34.0
* **core:** `App.run()` was renamed to `App.synth()` (soft deprecation, it will be removed in the next release).
* **core:** The `Stack.autoDeploy` feature has been removed. You can use `cdk deploy STACK ...` to determine which stacks to deploy (and wildcards are supported, so `cdk deploy '*'` will deploy all stacks. We plan to change the CLI to require specifying stacks if there is more than a single stack in the app (#2750).
* **core:** `ConstructNode.aspects` is now private.
* **core:** The `Synthesizer` has been removed. Use `ConstructNode.synth(node)` instead.
* **core:** `ISynthesizable.synthesize` now accepts an `ISynthesisSession` which contains the `CloudAssemblyBuilder` object. This will allow further extension in the future.
* **cx-api:** `cxapi.MissingContext` now includes the context `key`
* **core:** `Stack.reportMissingContext` now accepts a single argument of type `cxapi.MissingContext`, which includes the missing context key
* **core:** `Stack.annotatePhysicalName` has been removed (not used).
* **core:** `Stack.missingContext` is now private.
* **cx-api:** Multiple changes to the cloud assembly APIs to reduce surface area and clean up.
* **cdk-integ (private):** if an integration test includes multiple stacks, use `/// !cdk-integ STACK ...`  to explicitly specify which stacks to include in the test.
This was referenced Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment