Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static method which grants PutMetricData() to Metric #214

Closed
rix0rrr opened this issue Jul 2, 2018 · 0 comments · Fixed by #258
Closed

Add static method which grants PutMetricData() to Metric #214

rix0rrr opened this issue Jul 2, 2018 · 0 comments · Fixed by #258

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Jul 2, 2018 •
edited
Loading

Something like:

Metric.grantPutMetricData(lambda.role);

Suggestions for alternative names welcomed before we lock this in.
rix0rrr pushed a commit that referenced this issue Jul 9, 2018
feat(cloudwatch): add static helper function to grant metric writing …
6623384 
…permissions

This fixes #214.
@rix0rrr rix0rrr mentioned this issue Jul 9, 2018
Merged
rix0rrr added a commit that referenced this issue Jul 9, 2018
@rix0rrr
feat(cloudwatch): add static helper function to grant metric writing … (
ce967d9 
#258)

* feat(cloudwatch): add static helper function to grant metric writing permissions

This fixes #214.

* Address review comments

* Update changelog
rix0rrr pushed a commit that referenced this issue Jul 9, 2018
CloudWatch: add Metric.grantMetricPutData
f241cac 
This adds a static helper function on `Metric` to grant
metric writing permissions to IAM identities.

Also move the `parseStatistics` function to a private
source file so the unexported types it uses won't break
the jsii build.

Fixes #214.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cloudwatch): add static helper function to grant metric writing … aws/aws-cdk
1 participant
@rix0rrr