refactor(sns): move subscribers to aws-sns-subscribers
#2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In accordance with new guidelines, we're centralizing cross-service integrations into their own package. In this case, centralizing SNS Subscribers into @aws-cdk/aws-sns-subscribers. BREAKING CHANGE: using a queue, lambda, email, URL as SNS Subscriber now requires an integration object from the `@aws-cdk/aws-sns-subscribers` package.
eladb
suggested changes
Jun 10, 2019
| @@ -62,7 +63,7 @@ export class ManualApprovalAction extends codepipeline.Action { | |||
| if (this._notificationTopic) { | |||
| this._notificationTopic.grantPublish(info.role); | |||
| for (const notifyEmail of this.props.notifyEmails || []) { | |||
| this._notificationTopic.subscribeEmail(`Subscription-${notifyEmail}`, notifyEmail); | |||
| this._notificationTopic.subscribe(new subs.EmailSubscriber(notifyEmail)); | |||
4 tasks
eladb
approved these changes
Jun 10, 2019
| "@aws-cdk/cdk": "^0.33.0" | ||
| }, | ||
| "engines": { | ||
| "node": ">= 8.10.0" | ||
| }, | ||
| "awslint": { | ||
| "exclude": [ | ||
| "construct-base-is-private:@aws-cdk/aws-sns.TopicBase" | ||
| "construct-base-is-private:@aws-cdk/aws-sns.TopicBase", | ||
| "integ-return-type:@aws-cdk/aws-sns.ITopicSubscription.bind" |
There was a problem hiding this comment.
I think we should update the awslint rule to allow void as a return type for bind
| @@ -530,7 +530,7 @@ export class Construct implements IConstruct { | |||
| * Return whether the given object is a Construct | |||
| */ | |||
| public static isConstruct(x: any): x is Construct { | |||
| return CONSTRUCT_SYMBOL in x; | |||
| return typeof x === 'object' && x !== null && CONSTRUCT_SYMBOL in x; | |||
There was a problem hiding this comment.
We should make sure all of our isXxx methods are implemented like this.
| @@ -20,7 +21,7 @@ public HelloStack(Construct parent, string id, IStackProps props) : base(parent, | |||
| DisplayName = "My First Topic Yeah" | |||
| }); | |||
|
|
|||
| topic.SubscribeQueue(queue, null); | |||
| topic.AddSubscription(new SqsSubscription(queue, null)); | |||
There was a problem hiding this comment.
I believe .NET does not support optional arguments
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with new guidelines, we're centralizing cross-service
integrations into their own package. In this case, centralizing
SNS Subscribers into @aws-cdk/aws-sns-subscribers.
BREAKING CHANGE: using a queue, lambda, email, URL as SNS Subscriber now
requires an integration object from the
@aws-cdk/aws-sns-subscriberspackage.
Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.