Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecs: set the default value of HealthCheckGracePeriodSeconds to 60 seconds #2936

Closed
hencrice opened this issue Jun 19, 2019 · 0 comments · Fixed by #2942 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Closed

ecs: set the default value of HealthCheckGracePeriodSeconds to 60 seconds #2936

hencrice opened this issue Jun 19, 2019 · 0 comments · Fixed by #2942 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved.

Comments

@hencrice
Copy link
Contributor

hencrice commented Jun 19, 2019 •
edited

This is intended for the FIXME comment https://github.com/hencrice/aws-cdk/blob/master/packages/%40aws-cdk/aws-ecs/lib/base/base-service.ts#L67. This was brought up as an action item in the ECS CDK API review.

I checked with our team and they seem to think 60 seconds is a sensible starting point. The default should only kicks in if HealthCheckGracePeriodSeconds is not already set by customers and at least one LB is configured.
@hencrice hencrice added the feature-request A feature should be added or improved. label Jun 19, 2019
@hencrice hencrice mentioned this issue Jun 19, 2019
Merged
3 tasks
@NGL321 NGL321 added @aws-cdk/aws-ecs Related to Amazon Elastic Container gap labels Jun 20, 2019
rix0rrr pushed a commit that referenced this issue Jun 21, 2019
@hencrice @rix0rrr
feat(ecs): set default health check grace period to 60s (#2942)
0535d36 
Set the default `HealthCheckGracePeriodSeconds` in base-service to 60 seconds if it's not already set and at least one load balancer is configured

This was a FIXME in the ECS CDK codebase.

Closes #2936.
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 20, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs): set default HealthCheckGracePeriodSeconds
[Snyk] Upgrade @aws-cdk/aws-iam from 0.22.0 to 0.39.0 MechanicalRock/tech-radar
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-s3 from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-cloudfront from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codecommit from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-cloudfront from 0.22.0 to 0.39.0 MechanicalRock/tech-radar
2 participants
@hencrice @NGL321