Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDS Cluster does not expose read endpoint correctly #2969

Closed
rpanfili opened this issue Jun 20, 2019 · 0 comments · Fixed by #2970 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Closed

RDS Cluster does not expose read endpoint correctly #2969

rpanfili opened this issue Jun 20, 2019 · 0 comments · Fixed by #2970 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Labels
bug This issue is a bug.

Comments

@rpanfili
Copy link
Contributor

There is a typo in RDS DatabaseCluster class so it exposes the write endpoint on property clusterReadEndpoint

The issue is here
https://github.com/awslabs/aws-cdk/blob/0dabb024a3ed136a0624d9a9a55561cc5e301147/packages/%40aws-cdk/aws-rds/lib/cluster.ts#L333

and can be easily fixed with this

    this.clusterReadEndpoint = new Endpoint(cluster.attrReadEndpointAddress, portAttribute);
@rpanfili rpanfili added the bug This issue is a bug. label Jun 20, 2019
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 20, 2019
@rpanfili
fix(rds): DatabaseCluster exposes read endpoint
57be736 
Fix a typo that exposes cluster write endpoint as `clusterReadEndpoint`
on RDS DatabaseCluster

fixes aws#2969
@rpanfili rpanfili mentioned this issue Jun 20, 2019
Merged
4 tasks
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 21, 2019
@rpanfili
fix(rds): DatabaseCluster exposes read endpoint
8f7ca98 
Fix a typo that exposes cluster write endpoint as `clusterReadEndpoint`
on RDS DatabaseCluster

fixes aws#2969
rpanfili added a commit to rpanfili/aws-cdk that referenced this issue Jun 21, 2019
@rpanfili
fix(rds): DatabaseCluster exposes read endpoint
fea8853 
Fix a typo that exposes cluster write endpoint as `clusterReadEndpoint`
on RDS DatabaseCluster

fixes aws#2969
rix0rrr pushed a commit that referenced this issue Jun 21, 2019
@rpanfili @rix0rrr
fix(rds): correctly expose DatabaseCluster's read endpoint (#2970)
2d50c18 
Fix a typo that exposes cluster write endpoint as `clusterReadEndpoint` on RDS DatabaseCluster

Fixes #2969.
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 20, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rds): DatabaseCluster exposes read endpoint rpanfili/aws-cdk
[Snyk] Upgrade @aws-cdk/aws-iam from 0.22.0 to 0.39.0 MechanicalRock/tech-radar
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-s3 from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-cloudfront from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codecommit from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-cloudfront from 0.22.0 to 0.39.0 MechanicalRock/tech-radar
1 participant
@rpanfili