Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codepipeline-actions): set service as backing resource for EcsDeployAction #3085

Merged
merged 2 commits into from Jun 27, 2019

Conversation

strax
Copy link
Contributor

@strax strax commented Jun 26, 2019

Adds cross-account deployment support to EcsDeployAction CodePipeline action by setting the ActionProperties.resource property introduced in #3012 to the target ECS service.

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@strax strax requested review from RomainMuller, skinny85 and a team as code owners June 26, 2019 15:20
@eladb eladb merged commit f2293e0 into aws:master Jun 27, 2019
@skinny85
Copy link
Contributor

skinny85 commented Jun 27, 2019

Thanks for the subtle PR @strax !

Note that I haven't explicitly tested whether cross-account support works for ECS services (yet) - it might be that we will need to create some Roles inside the service, for example, with a lazy-assigned physical name. Let us know what you find out!

Thanks,
Adam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants