fix(aws-codepipeline-actions): use SecretValue #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdk.SecretValue has replaced cdk.SecretParameter but the README was outdated.
samuelkarp
requested review from
RomainMuller,
skinny85 and
a team
as code owners
skinny85
reviewed
Jun 27, 2019
| @@ -56,7 +56,7 @@ To use GitHub as the source of a CodePipeline: | |||
|
|
|||
| ```typescript | |||
| // Read the secret from ParameterStore | |||
| const token = new cdk.SecretParameter(this, 'GitHubToken', { ssmParameter: 'my-github-token' }); | |||
| const token = cdk.SecretValue.ssmSecure('my-github-token','1'); | |||
There was a problem hiding this comment.
Unfortunately, we have a problem here. CodePipeline does not accept SSM Secure parameters (only Plain Text ones), and trying to deploy with it results in an error like:
❌ Pipeline failed: ValidationError: SSM Secure reference is not supported in:
[AWS::CodePipeline::Pipeline/Properties/Stages,AWS::CodePipeline::Webhook/Properties/AuthenticationConfiguration/SecretToken]
We need to change this example to use cdk.SecretValue.secretsManager().
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cdk.SecretValue has replaced cdk.SecretParameter but the README was
outdated.
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license