fix(cli): stop processing on metadata errors #3168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new stack selection short circuiting broke stack error checking, which happened further down in that function. Move that functionality out as an explicit step to the CLI, as opposed to doing it implicitly as part of 'selectStacks'. NOTE: no test here, should be an integration test but the test will fail on the previous release so created a ticket for it.
ghost
requested a review
from 
eladb
approved these changes
Jul 2, 2019
| @@ -269,7 +266,7 @@ export class AppStacks { | |||
| /** | |||
| * Extracts 'aws:cdk:warning|info|error' metadata entries from the stack synthesis | |||
| */ | |||
| private processMessages(stacks: cxapi.CloudFormationStackArtifact[]) { | |||
| public processMetadata(stacks: cxapi.CloudFormationStackArtifact[]) { | |||
There was a problem hiding this comment.
Why not call this processMessages, isn't it more accurate?
Kaixiang-AWS
pushed a commit
to Kaixiang-AWS/aws-cdk
that referenced
this pull request
Jul 3, 2019
The new stack selection short circuiting broke stack error checking, which happened further down in that function. Move that functionality out as an explicit step to the CLI, as opposed to doing it implicitly as part of 'selectStacks'. NOTE: no test here, should be an integration test but the test will fail on the previous release so created a ticket for it.
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new stack selection short circuiting broke stack error checking,
which happened further down in that function. Move that functionality
out as an explicit step to the CLI, as opposed to doing it implicitly
as part of 'selectStacks'.
NOTE: no test here, should be an integration test but the test will fail
on the previous release so created a ticket for it.
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license