Lambda: add global metric for ConcurrentExecutions #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
reviewed
Jul 19, 2018
| * @default max over 5 minutes | ||
| */ | ||
| public static metricAllConcurrentExecutions(props?: MetricCustomization): Metric { | ||
| // Mini-FAQ: why max? This metric is a gauge that is emitted every |
There was a problem hiding this comment.
Why not put this documentation in the jsdocs?
There was a problem hiding this comment.
I wonder if it's not too detailed to put in the jsdocs.
eladb
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under
the terms of the beta license.