aws-cdk-java: Normalize maven usage #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 20, 2018 15:35
Passing through JSON requests through shell scripts can easily cause escaping hell, since double-quotes are parsed by the shell and omitted. Once those requests need to hop through two shell scripts, it is practically impossible to escape them probably, and the last thing we want. To completely eliminate the need to escape, cx-api now supports accepting requests with base64 encoding. Those are prefixed by the string "base64:", decoded and then parsed as JSON. To decode base64, a bundled dependency on js-base64 was added. Misc: if an errors occurs, toolkit emits contents of STDOUT to allow diagnostics.
* Use a generated pom.xml to plug-in version numbers * Emit a local maven repo directory structure to `maven-repo`
RomainMuller
approved these changes
Jun 20, 2018
added 4 commits
June 20, 2018 16:00
* Includes better support for maven packaging
added 9 commits
June 20, 2018 17:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maven-repoBy submitting this pull request, I confirm that my contribution is made under
the terms of the beta license.