Make execution of pack.sh much faster
#161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the `pack.sh` script is supposed to be run after `build.sh` was executed, the `prepare` script of all packages was already performed, and it is possible to only run the `prepublish` script, then execute `npm pack --ignore-scripts` in parallel. This removes the double-compilation of all packages (including slow-to-build packages such as `aws-cdk-docs` or `@aws-cdk/resources`, that involve expensive code generation).
eladb
approved these changes
Jun 21, 2018
|
Can we port this change to awslabs/jsii as well? |
|
@eladb - I'll see to have the same in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
pack.shscript is supposed to be run afterbuild.shwasexecuted, the
preparescript of all packages was already performed,and it is possible to only run the
prepublishscript, then executenpm pack --ignore-scriptsin parallel.This removes the double-compilation of all packages (including
slow-to-build packages such as
aws-cdk-docsor@aws-cdk/resources,that involve expensive code generation).