Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make it possible to generate a subset of target languages in pack.sh #1730

Merged
merged 33 commits into from Mar 18, 2019

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Feb 11, 2019


Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@eladb eladb requested a review from a team as a code owner February 11, 2019 20:16
@rix0rrr rix0rrr closed this Feb 27, 2019
@rix0rrr rix0rrr reopened this Feb 27, 2019
@rix0rrr rix0rrr changed the title [WIP] New reference documentation website chore: make it possible to generate a subset of target languages in pack.sh Feb 27, 2019
@eladb
Copy link
Contributor Author

eladb commented Mar 17, 2019

Why does it look like I have submitted this PR?

@rix0rrr
Copy link
Contributor

rix0rrr commented Mar 18, 2019

You created the PR for this branch originally (docs work), and then I moved most of the code out. All that's left in this change now are a couple of script enhancements.

@eladb
Copy link
Contributor Author

eladb commented Mar 18, 2019

And the branch is samgood/docs 😂

@rix0rrr rix0rrr merged commit 130e2d0 into master Mar 18, 2019
@rix0rrr rix0rrr deleted the samgood/docs branch March 18, 2019 11:53
rix0rrr pushed a commit to alex-berger/aws-cdk that referenced this pull request Mar 19, 2019
Update the build tools to take an argument to pack only a subset of language targets.
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 23, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants