Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for upserting to MySQL #608

Closed
senorkrabs opened this issue Mar 18, 2021 · 2 comments · Fixed by #613
Closed

Support for upserting to MySQL #608

senorkrabs opened this issue Mar 18, 2021 · 2 comments · Fixed by #613
Assignees
@mattboyd-aws
Labels
enhancement New feature or request minor release Will be addressed in the next minor release ready to release
Milestone
2.7.0

Comments

@senorkrabs
Copy link

senorkrabs commented Mar 18, 2021 •
edited

Is your feature request related to a problem? Please describe.
For ETL jobs I would like the ability to upsert a Data Frame into an existing table, rather than overwriting or append. The mysql class doesn't have this option at the moment, as far as I can tell.

Describe the solution you'd like

  • An optional parameter upsert when calling to_sql
  • In researching, appending an ON DUPLICATE KEY statement to the SQL should allow for upserting in most situations

I'm planning to investigate and test this a bit and, if successful, will make a PR.
@mattboyd-aws mattboyd-aws mentioned this issue Mar 21, 2021
Merged
@jaidisido jaidisido added enhancement New feature or request minor release Will be addressed in the next minor release ready to release and removed feature labels Mar 22, 2021
@jaidisido jaidisido linked a pull request Mar 23, 2021 that will close this issue
Mysql upsert #613
Merged
@jaidisido jaidisido added this to the 2.7.0 milestone Apr 6, 2021
@mattboyd-aws
Copy link
Contributor

mattboyd-aws commented Apr 6, 2021 •
edited

Could you reassign to mattboyd-aws? This is my work account, senorkrabs is personal. Sorry for the confusion :)

@jaidisido jaidisido assigned mattboyd-aws and unassigned senorkrabs Apr 6, 2021
@jaidisido
Copy link
Contributor

Covered in 2.7.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattboyd-aws mattboyd-aws

Labels
enhancement New feature or request minor release Will be addressed in the next minor release ready to release
Projects
None yet
Milestone
2.7.0
Development

Successfully merging a pull request may close this issue.

Mysql upsert mattboyd-aws/aws-data-wrangler
3 participants
@jaidisido @senorkrabs @mattboyd-aws