(feat): Add distributed config flag and initialise method #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaidisido
commented
Jun 13, 2022
kukushking
reviewed
Jun 13, 2022
awswrangler/_distributed.py
Outdated
| import ray | ||
|
|
||
|
|
||
| def _ray_remote(function: Callable[..., Any]) -> Any: |
There was a problem hiding this comment.
Since both _ray_remote and _initialize_ray are used in other modules shall we make them public (no underscore)?
There was a problem hiding this comment.
They won't be exposed to the user so not sure why we should make them public. There are plenty of examples of private methods in the codebase that are reused yet not exposed and left private
There was a problem hiding this comment.
Public relative to the module
|
Also, just curious - since this is basically taken from here any reason to leave out the context manager? Do we not want to add that option? |
kukushking
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.