Refactor threading/ray; add single-path distributed s3 select impl #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add ray pool & thread pool executor wrapper - add single-path distributed s3 select impl - refactor distributed lakeformation impl
jaidisido
changed the title
jaidisido
reviewed
Jul 11, 2022
| def __init__(self, processes: Optional[Union[bool, int]] = None): | ||
| self._exec: Pool = Pool(processes=None if isinstance(processes, bool) else processes) | ||
|
|
||
| def map(self, func: Callable[..., List[str]], _: boto3.Session, *args: Any) -> List[Any]: |
There was a problem hiding this comment.
Does this assume that the first argument after func must always be a boto3_session? Don't you think it's the kind of opaque knowledge that external/new contributors wouldn't know about?
There was a problem hiding this comment.
I basically followed the same convention we're using in WriteProxy and to be honest I prefer an explicit convention over any other trickery (e.g. picking out kwargs) but happy to discuss
jaidisido
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.