Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding subdir for Distributed Wrangler Load Tests #1464

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

malachi-constant
Copy link
Contributor

Feature

  • Adds dedicated directory for load tests for distributed wrangler methods

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant added the enhancement New feature or request label Jul 20, 2022
@malachi-constant malachi-constant self-assigned this Jul 20, 2022
@malachi-constant
Copy link
Contributor Author

Two things.

  1. Do we want to keep our load tests in a dedicated subdirectory? I figured adding them to tests/ may end up polluting CI as it runs pytest tests/*

  2. @jaidisido I tried putting in a decorator to handle elapsed time, but was having trouble getting pytest to collect the functions when decorated. E.g.

import time
from functools import wraps


def elapsed_time(func):
    @wraps(func)
    def elapsed_time_wrapper(*args, **kwargs):
        start_time = time.perf_counter()
        result = func(*args, **kwargs)
        end_time = time.perf_counter()
        total_time = end_time - start_time
        print(f"Function {func.__name__}{args} {kwargs} Took {total_time:.4f} seconds")
        return result

    return

PytestCollectionWarning: cannot collect 'test_s3_select' because it is not a function. def __call__(self, *args: object, **kwargs: object):

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubLoadTests5656BB24-s6u9F3qN9oFy
  • Commit ID: a4800d6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido
Copy link
Contributor

  1. I am in favour of separating load_tests into their own directory like you suggest. @kukushking / @cnfait what do you think?
  2. Should we simply use the --durations=0 flag of pytest?

@malachi-constant malachi-constant merged commit bd19377 into release-3.0.0 Jul 21, 2022
@jaidisido jaidisido deleted the add-load-tests branch July 22, 2022 11:34
@malachi-constant malachi-constant moved this from Review to Done in Roadmap II (Deprecated) Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants