Fixing nested struct bug in athena2pyarrow method #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaidisido
added
bug
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#585
Description of changes:
The
athena2pyarrowmethod has recursive calls forarray,structandmaptypes (i.e. it's calling itself for these types). We should therefore be passing the original dtype to each recursive call, not the modified dtype. Otherwise, the returned pyarrow type won't match the one in the table.Example:
For a column
'onboardcountdetails': 'array<struct<CarRef:string,OnboardCount:int>>'the current implementation of theathena2pyarrowwould return a pyarrow type oflist<item: struct<carref: string, onboardcount: int32>>(notice the lowercasecarrefandonboardcount) which causes a mismatch in columns.This fix would return
list<item: struct<CarRef: string, OnBoardCount: int32>>which is correctBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.