Fix bucketing types #719
Merged
Fix bucketing types #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Nice catch, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
During testing some bucketing I've noticed a problem when there are combined datatypes in some rows which cause dtype casting during
df.apply. As duringdf.applyeach row is handled as a separate Series and for example there is afloatand aintcolumn, thedtypeof the row series isfloatand the Exception is raised.To prevent this issue the fix according to https://stackoverflow.com/a/47145613/10608063 was added which changes the
dtypetoobjectbeforeapply.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.