Removing explicit Excel engine configuration #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaidisido
added
bug
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
kukushking
reviewed
Jun 11, 2021
tests/test_s3_excel.py
Outdated
| df2 = wr.s3.read_excel(file_path, use_threads=use_threads) | ||
| assert df.equals(df2) | ||
|
|
||
| for ext in ["xlsx", "xlsm", "xls", "odf"]: |
There was a problem hiding this comment.
Did you consider parametrising the test instead?
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#739
Description of changes:
Removing explicit Excel engine configuration from s3 read and write excel methods. Instead, Wrangler delegates engine choice to Pandas.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.