Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tables synchronisation does not delete tables in data.all #81

Closed
louishourcade opened this issue Jul 11, 2022 · 2 comments · Fixed by #89
Closed

Tables synchronisation does not delete tables in data.all #81

louishourcade opened this issue Jul 11, 2022 · 2 comments · Fixed by #89
Assignees
@louishourcade
Labels
type: bug Something isn't working
Projects
v1.2.0

Comments

@louishourcade
Copy link
Contributor

Describe the bug

When I delete tables from the Glue data catalog, and click on the "Synchronize" button of the dataset, deleted tables still appear in data.all.

How to Reproduce

  • Take an existing dataset with some tables
  • Delete tables from the Glue Data Catalog
  • Click on "Synchronize"

Deleted tables are still visible on data.all

Expected behavior

Synchronize should provide the same view in data.all and Glue Data Catalog

Your project

No response

Screenshots

No response

OS

Linux

Python version

3.9

AWS data.all version

1.0.0

Additional context

No response
@louishourcade louishourcade added the type: bug Something isn't working label Jul 11, 2022
@louishourcade
Copy link
Contributor Author

@dlpzx you can assign me on this one

@dlpzx dlpzx added this to Features requested in v1.2.0 via automation Jul 11, 2022
@dlpzx dlpzx moved this from Features requested to Features selected for implementation in v1.2.0 Jul 12, 2022
@louishourcade louishourcade mentioned this issue Jul 19, 2022
Merged
@dlpzx dlpzx linked a pull request Jul 19, 2022 that will close this issue
Delete tables from data.all when they are deleted in Glue #89
Merged
@dlpzx dlpzx closed this as completed Jul 19, 2022
v1.2.0 automation moved this from Features selected for implementation to Done Jul 19, 2022
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louishourcade louishourcade

Labels
type: bug Something isn't working
Projects
No open projects
v1.2.0
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete tables from data.all when they are deleted in Glue louishourcade/aws-dataall
2 participants
@louishourcade @dlpzx