Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove frame-size block-length restriction #42

Closed
SalusaSecondus opened this issue Nov 30, 2017 · 2 comments
Closed

Remove frame-size block-length restriction #42

SalusaSecondus opened this issue Nov 30, 2017 · 2 comments
Assignees

Comments

@SalusaSecondus
Copy link
Contributor

While we may need to support non-stream ciphers at some point, currently our only bulk cipher is AES-GCM which has no block size restrictions. Thus, we can (and should) remove the restriction that our frame-sizes be a multiple of 16.

https://github.com/awslabs/aws-encryption-sdk-java/blob/master/src/main/java/com/amazonaws/encryptionsdk/AwsCrypto.java#L140

This change should be completely backwards compatible as this restriction is only enforced on the encrypt path and not the decrypt path. As part of this change, backwards compatibility will be manually tested.

Additionally, this task will also be completed in aws-encryption-sdk-python

@SalusaSecondus
Copy link
Contributor Author

See issue aws-encryption-sdk-python#30

@SalusaSecondus
Copy link
Contributor Author

Base64 encoded ciphertext using a 15 byte block-size. This has been confirmed as decryptable via the aws-encryption-sdk-cli which using the python implementation internally.

AYADeM4hjbiamPp3iXnwZoz+IkQAXwABABVhd3MtY3J5cHRvLXB1YmxpYy1rZXkAREExdUJoUW0yc1hZWTk5S1NkYXJVcjRDN0x5WTlxd1o5L0JrOFhuMjdwYzdUODVMTTdtM2RaalBPZzVVV2Y5YW5WZz09AAIAB2F3cy1rbXMAS2Fybjphd3M6a21zOnVzLXdlc3QtMjo2NTg5NTY2MDA4MzM6a2V5L2IzNTM3ZWYxLWQ4ZGMtNDc4MC05ZjVhLTU1Nzc2Y2JiMmY3ZgCnAQEBAHhA84wnXjEJdBbBBylRUFcZZK2j7xwh6UyLoL28nQ+0FAAAAH4wfAYJKoZIhvcNAQcGoG8wbQIBADBoBgkqhkiG9w0BBwEwHgYJYIZIAWUDBAEuMBEEDCZX1wU5fDCyX+Am9wIBEIA7RpItoEBOjhQzvyp3zDvJTXLLX0Z+TqroeiqC2ypiSvp3qAHPcbjCUPm3otYAwf+XdaN8wmmM6Y+R25sAB2F3cy1rbXMATmFybjphd3M6a21zOmV1LWNlbnRyYWwtMTo2NTg5NTY2MDA4MzM6a2V5Lzc1NDE0YzkzLTUyODUtNGI1Ny05OWM5LTMwYzFjZjBhMjJjMgCnAQECAHhpJnHNhxTb+pGIUToV1eANxoxSoEUMxxMR4xlifYIGHQAAAH4wfAYJKoZIhvcNAQcGoG8wbQIBADBoBgkqhkiG9w0BBwEwHgYJYIZIAWUDBAEuMBEEDIbGweY+2sPfj1maeQIBEIA7Z2JiAspOWHA9TXJ9/4mpjdWzYBqQUQvC0qNGixH5CsgElkYAT94s/KBBakcuUiwqW7VNoKOyHqgyrjECAAAAAAwAAAAPAAAAAAAAAAAAAAAA24jZ+wTt58UvuUtFva6fngAAAAEAAAAAAAAAAAAAAAFfrxCiBAdIEO/fwZJvd02JIH817tj2etlH795oFlP1AAAAAgAAAAAAAAAAAAAAAnyatX/b6BJBeoqeyyo8Q+GDu8eCUo8O0xLNBuRR4Y4AAAADAAAAAAAAAAAAAAADHTAAkSsWx28tQhfv7tkPCGV33OtuV0opiXJxmHFuBgAAAAQAAAAAAAAAAAAAAARS4DUGlWVT/bCUoT9qdg9tmPOSDWhdCUvlDA/yMpabAAAABQAAAAAAAAAAAAAABaxoKhWQtMcFpX9a5GrwCFL8qabwGqH3+QERUxCUcG4AAAAGAAAAAAAAAAAAAAAGC9ALLMhdAn0dBtcWjrhAMHmeVOgfU404Dszn1Uj1qgAAAAcAAAAAAAAAAAAAAAekOpjIt2XJ0Sp01gJfrDJrmUVKps8IrliAn7SVdDSI/////wAAAAgAAAAAAAAAAAAAAAgAAAAF0R67cEXsmac8RNBnAiBILbAANmd1AGcwZQIxAMnVDGW4C9dp5NbYqz9pCqAyXfpiovB2GdsfWmivFvkGeWI2CrN8S7Sk/s+EplUS+QIwMxg7l6hVlQ+jpR/raHsYgYPPVlKUyby9DbGtzuWLLI71+iTCzC5XaLrKBPlmMpHJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant