Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Explain the use of AWS X-Ray SDK over the OpenTelemetry/ADOT for tracing instrumentation #1675

Closed
1 task done
Dilski opened this issue Oct 31, 2022 · 5 comments
Closed
1 task done
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Dilski
Copy link

Dilski commented Oct 31, 2022

What were you searching in the docs?

At time of writing, the AWS X-Ray SDK for Python project recommends the following:

AWS X-Ray recommends using AWS Distro for OpenTelemetry (ADOT) to instrument your application instead of this X-Ray SDK due to its wider range of features and instrumentations.

However the AWS Lambda Powertools, whose aim is to "..to ease adopting best practices such as tracing...", uses the X-Ray SDK. This could be confusing for folks looking for AWS's recommended best practices regarding how to trace their Python Lambda functions.

Is this related to an existing documentation section?

No response

How can we improve?

It would be useful to include documentation in the Tracing powertools docs page to explain the reasons for using the X-Ray SDK in python lambda functions (and why ADOT is not yet used by Powertools).

Separately, the X-Ray developer guide should include this information in it's section "Choosing between the AWS Distro for OpenTelemetry and X-Ray SDKs".

Got a suggestion in mind?

No response

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@Dilski Dilski added documentation Improvements or additions to documentation triage Pending triage from maintainers labels Oct 31, 2022
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Nov 1, 2022
@heitorlessa
Copy link
Contributor

Thanks for opening the issue @Dilski :) Quick update: We spoke to the X-Ray SDK team and they'll update the repository and Docs to better reflect when OTel/ADOT is recommended.

From our side, we should have this by Friday EOD

@heitorlessa heitorlessa self-assigned this Nov 1, 2022
@Dilski
Copy link
Author

Dilski commented Nov 1, 2022

@heitorlessa thanks a bunch!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@heitorlessa
Copy link
Contributor

hey @Dilski this is now available as part of 2.2.0 release - lemme know if that doesn't suffice.

Lambda docs have also been updated with the following - marked the specific in bold (X-Ray docs is WIP):

ADOT is the preferred method for instrumenting your Lambda functions. We recommend using ADOT for all new applications. However, due to the flexibility OpenTelemetry offers, your Lambda function invocations may experience cold start latency increases. If you're optimizing for low-latency and also do not require OpenTelemetry's advanced capabilities such as telemetry correlation and dynamically configurable backend destinations, you may want to use the AWS X-Ray SDK over ADOT.

image

Thank you again for helping us be more precise on multiple channels.

@Dilski
Copy link
Author

Dilski commented Nov 9, 2022

@heitorlessa amazing, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants