Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apigateway): support nested router decorators #1709

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

kmkhr
Copy link
Contributor

@kmkhr kmkhr commented Nov 14, 2022

Issue number: #1712

Summary

Changes

Please provide a summary of what's being changed

This PR fixes a bug router decorator cannot be nested.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@kmkhr kmkhr requested a review from a team as a code owner November 14, 2022 08:31
@kmkhr kmkhr requested review from leandrodamascena and removed request for a team November 14, 2022 08:31
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2022
@heitorlessa heitorlessa changed the title fix(apigateway): allow nested router decorators feat(apigateway): support nested router decorators Nov 14, 2022
@github-actions github-actions bot added the bug Something isn't working label Nov 14, 2022
@heitorlessa
Copy link
Contributor

Hi @kt-hr could you create a feature request for this? We'd happily accept your PR after that, since this isn't a bug nor related to the exception handler.

Thanks a lot!

@github-actions github-actions bot added the feature New feature or functionality label Nov 14, 2022
@kmkhr
Copy link
Contributor Author

kmkhr commented Nov 14, 2022

Hi @heitorlessa , Thanks for commenting. I will create a feature request.

I thought it was a bug based on the difference in behavior between ApiGatewayResolver and Router , but would it be a feature request?

@heitorlessa
Copy link
Contributor

You're right @kt-hr. It's a bug as the legacy ApiGatewayResolver returns the function correctly. I missed that from the description and the issue linked leading to me to believe otherwise.

Thank you!

@heitorlessa heitorlessa changed the title feat(apigateway): support nested router decorators fix(apigateway): support nested router decorators Nov 14, 2022
@heitorlessa heitorlessa removed the feature New feature or functionality label Nov 14, 2022
@heitorlessa
Copy link
Contributor

I'll create a quick maintenance issue for that discrepancy, then merge this PR. Hang tight

@heitorlessa heitorlessa removed the request for review from leandrodamascena November 14, 2022 16:14
@heitorlessa
Copy link
Contributor

made a tiny change on test comments only. Thanks a lot for providing tests upfront, much appreciated!

Merging.

@heitorlessa heitorlessa merged commit 8862e69 into aws-powertools:develop Nov 14, 2022
@kmkhr kmkhr deleted the fix/nested-agw-decorator branch November 15, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working event_handlers size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants