Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): export Pydantic.errors through escape hatch #1728

Conversation

heitorlessa
Copy link
Contributor

Issue number: #1687

Summary

Changes

Please provide a summary of what's being changed

This PR exports all errors available in pydantic.errors through parser's pydantic escape hatch.

User experience

Please share what the user experience looks like before and after this change

image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team as a code owner November 16, 2022 14:06
@heitorlessa heitorlessa requested review from leandrodamascena and removed request for a team November 16, 2022 14:06
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2022
@github-actions github-actions bot added the feature New feature or functionality label Nov 16, 2022
@heitorlessa
Copy link
Contributor Author

Just read Pydantic V2 plan and the only breaking change it seems to apply here is parse_raw that we use in Parser. I couldn't find a specific mention on errors packaging.

Did the due-diligence and merging since all other maintainers are unavailable.

@heitorlessa heitorlessa linked an issue Nov 17, 2022 that may be closed by this pull request
2 tasks
@heitorlessa heitorlessa merged commit d7fc2b8 into aws-powertools:develop Nov 17, 2022
@heitorlessa heitorlessa deleted the feat/parser-expose-pydantic-errors branch November 17, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parser (Pydantic) re-export Pydantic errors for data model validation
1 participant