Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(idempotency): add missing Lambda Context; note on thread-safe #1732

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Nov 17, 2022

Issue number: #1718

Summary

Changes

Please provide a summary of what's being changed

Add missing LambdaContext for Testing your code section, and a note on thread-safety limitation when calling functions decorated with idempotent_function via threading.

User experience

Please share what the user experience looks like before and after this change

image

image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.


View rendered docs/utilities/idempotency.md

@heitorlessa heitorlessa requested a review from a team as a code owner November 17, 2022 11:33
@heitorlessa heitorlessa requested review from rubenfonseca and removed request for a team November 17, 2022 11:33
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Nov 17, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 17, 2022
@heitorlessa
Copy link
Contributor Author

Merging as all other maintainers are unavailable.

@heitorlessa heitorlessa changed the title docs(idempotency): add missing Lambda Context to testing your code se… docs(idempotency): add missing Lambda Context; note on thread-safe Nov 17, 2022
@heitorlessa heitorlessa merged commit 302a68e into aws-powertools:develop Nov 17, 2022
@heitorlessa heitorlessa deleted the docs/idempotency-testing-and-thread branch November 17, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant