Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(logger): fix incorrect field names in example structured logs #1830

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

aidansteele
Copy link
Contributor

Issue number: #1828

Summary

This addresses incorrect examples of structured logs in the documentation. The docs now match the current behaviour of the library.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aidansteele aidansteele requested a review from a team as a code owner January 12, 2023 05:10
@aidansteele aidansteele requested review from rubenfonseca and removed request for a team January 12, 2023 05:10
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 12, 2023

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our AWS Lambda Powertools Discord: Invite link

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 12, 2023
@rubenfonseca rubenfonseca linked an issue Jan 12, 2023 that may be closed by this pull request
1 task
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 12, 2023
Copy link
Contributor

@rubenfonseca rubenfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this improvement!! Much appreciated!

@rubenfonseca rubenfonseca merged commit 4efbdd4 into aws-powertools:develop Jan 12, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 12, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: injected Lambda context keys do not match documentation
2 participants