Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(event-source): fix incorrect method in example CloudWatch Logs #1857

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

ashutoshojha5
Copy link
Contributor

@ashutoshojha5 ashutoshojha5 commented Jan 24, 2023

Signed-off-by: Ashutosh Ojha ashutoshojha5@gmail.com

Issue number: #1867

Summary

Changes

event.parse_logs_data is used in CloudWatch Logs section as an object, but it is method and should be like event.parse_logs_data()

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

event.parse_logs_data is used in CloudWatch Logs section as an object, but it is method and should be like event.parse_logs_data()

Signed-off-by: Ashutosh Ojha <ashutoshojha5@gmail.com>
@ashutoshojha5 ashutoshojha5 requested a review from a team as a code owner January 24, 2023 21:13
@ashutoshojha5 ashutoshojha5 requested review from rubenfonseca and removed request for a team January 24, 2023 21:13
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jan 24, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 24, 2023

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our AWS Lambda Powertools Discord: Invite link

@rubenfonseca rubenfonseca added the need-issue PRs that are missing related issues label Jan 24, 2023
@leandrodamascena leandrodamascena removed the need-issue PRs that are missing related issues label Jan 27, 2023
@github-actions
Copy link
Contributor

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge need-issue PRs that are missing related issues labels Jan 27, 2023
@leandrodamascena leandrodamascena removed do-not-merge need-issue PRs that are missing related issues labels Jan 27, 2023
@leandrodamascena leandrodamascena changed the title event.parse_logs_data to event.parse_logs_data() docs(event-source): fix incorrect method names in example cloudwatch logs Jan 27, 2023
@leandrodamascena
Copy link
Contributor

Hello @ashutoshojha5 thank you very much for sending this PR. I opened an issue and linked to this PR because we need to keep track of all changes to the project.

@leandrodamascena leandrodamascena changed the title docs(event-source): fix incorrect method names in example cloudwatch logs docs(event-source): fix incorrect method names in example CloudWatch Logs Jan 27, 2023
@leandrodamascena leandrodamascena changed the title docs(event-source): fix incorrect method names in example CloudWatch Logs docs(event-source): fix incorrect method in example CloudWatch Logs Jan 27, 2023
@leandrodamascena leandrodamascena merged commit 0c6c14c into aws-powertools:develop Jan 27, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 27, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants