Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): make logs fetching more robust #1878

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Conversation

rubenfonseca
Copy link
Contributor

Issue number: #1877

Summary

Changes

Please provide a summary of what's being changed

This PR adds an optional field to the logger fetcher, where we could indicate how many
lines of logging we are expecting. If we fail to fetch that number, we use the existing
retry mechanism to try multiple times, before bailing out.

User experience

Please share what the user experience looks like before and after this change

This should help with some of the flaky e2e tests.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@rubenfonseca rubenfonseca requested a review from a team as a code owner January 31, 2023 10:45
@rubenfonseca rubenfonseca requested review from leandrodamascena and removed request for a team January 31, 2023 10:45
@boring-cyborg boring-cyborg bot added the tests label Jan 31, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 31, 2023
@github-actions github-actions bot added the bug Something isn't working label Jan 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Base: 97.51% // Head: 97.51% // No change to project coverage 👍

Coverage data is based on head (76f2054) compared to base (bea1c0e).
Patch has no changes to coverable lines.

❗ Current head 76f2054 differs from pull request most recent head f054cde. Consider uploading reports for the commit f054cde to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1878   +/-   ##
========================================
  Coverage    97.51%   97.51%           
========================================
  Files          143      143           
  Lines         6570     6570           
  Branches       466      466           
========================================
  Hits          6407     6407           
  Misses         128      128           
  Partials        35       35           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX change and complexity baseline suggestion.

Thanks for spotting this, we did the same in TraceFetcher before after hitting eventual consistency too.

tests/e2e/utils/data_fetcher/logs.py Outdated Show resolved Hide resolved
tests/e2e/utils/data_fetcher/logs.py Outdated Show resolved Hide resolved
rubenfonseca and others added 3 commits January 31, 2023 14:00
Co-authored-by: Heitor Lessa <lessa@amazon.com>
Signed-off-by: Ruben Fonseca <fonseka@gmail.com>
Co-authored-by: Heitor Lessa <lessa@amazon.com>
Signed-off-by: Ruben Fonseca <fonseka@gmail.com>
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@rubenfonseca rubenfonseca merged commit 04ee1d0 into develop Jan 31, 2023
@rubenfonseca rubenfonseca deleted the fix/e2e-logging branch January 31, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants