fix(feature-flags): revert RuleAction Enum inheritance on str #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR aws-powertools#1846 added a breaking change to RuleAction which not serializes the enum thus when used as an enum it breaks. Signed-off-by: royygael <116807865+royygael@users.noreply.github.com>
royygael
requested review from
leandrodamascena
and removed request for
a team
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
pull-request-size
bot
added
the
size/XS
heitorlessa
added
need-more-information
leandrodamascena
changed the title
leandrodamascena
changed the title
leandrodamascena
approved these changes
Feb 13, 2023
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
|
Thank you very much!
בתאריך יום ב׳, 13 בפבר׳ 2023 ב-14:16 מאת Leandro Damascena <
***@***.***>:
… ***@***.**** approved this pull request.
Approved!
Thanks you @royygael <https://github.com/royygael>!
—
Reply to this email directly, view it on GitHub
<#1910 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A33FROK6OYOG7VPOWDO6TR3WXIQZLANCNFSM6AAAAAAUVH6U4I>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
leandrodamascena
removed
need-more-information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: royygael 116807865+royygael@users.noreply.github.com
Issue number: #1909
Summary
The PR #1846 added a breaking change to RuleAction which not serializes the enum thus when used as an enum it breaks.
Changes
RuleAction should inherent str first to be dict serilizable
User experience
Breaking changes that now throws due to dict() func keeps the enum and not gives its value
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.