Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): clarify no-metrics user warning #1935

Conversation

rubenfonseca
Copy link
Contributor

Issue number: #1926

Summary

Changes

Please provide a summary of what's being changed

The user warning message printed when metrics are enabled but there are no application metrics to flush was changed to clarify
the behaviour.

User experience

Please share what the user experience looks like before and after this change

Previously, the message was very broad and could lead the user to believe that the cold start metric was not sent.

With this change, the message is now clear that the warning only applies to application metrics, and that the cold
start metric is still sent if enabled.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 16, 2023
@rubenfonseca rubenfonseca linked an issue Feb 16, 2023 that may be closed by this pull request
@github-actions github-actions bot added the bug Something isn't working label Feb 16, 2023
@rubenfonseca rubenfonseca marked this pull request as ready for review February 16, 2023 13:47
@rubenfonseca rubenfonseca requested a review from a team as a code owner February 16, 2023 13:47
@rubenfonseca rubenfonseca requested review from leandrodamascena and removed request for a team February 16, 2023 13:47
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leandrodamascena leandrodamascena merged commit 183f233 into aws-powertools:develop Feb 16, 2023
@rubenfonseca rubenfonseca deleted the rf/fix-no-metrics-message branch February 16, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metrics size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve warning message on Capturing ColdStart metrics
2 participants