Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data_classes): API Gateway V2 IAM and Lambda #201

Merged

Conversation

michaelbrewer
Copy link
Contributor

Issue #, if available:

Description of changes:

Update to support IAM and Lambda authorizer for API
Gateway V2 trigger events

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Update to support IAM and Lambda authorizer for API
Gateway V2 trigger events
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except missing docstrings in certain properties for consistency

For , this refers to the context parameters returned by the lambda authorizer (optional)
For , this refers to the IAM authorization details
@codecov-io
Copy link

codecov-io commented Nov 2, 2020

Codecov Report

Merging #201 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #201   +/-   ##
========================================
  Coverage    99.87%   99.87%           
========================================
  Files           67       67           
  Lines         2464     2499   +35     
  Branches       108      108           
========================================
+ Hits          2461     2496   +35     
  Misses           3        3           
Impacted Files Coverage Δ
.../utilities/data_classes/api_gateway_proxy_event.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d5986a...9926832. Read the comment docs.

@michaelbrewer
Copy link
Contributor Author

@heitorlessa - made those changes. I did have to did around into the cognito docs for some of them and parts of the IAM / Lambda authorizers docs

@heitorlessa
Copy link
Contributor

Looks great, thanks for those again @michaelbrewer !!

@heitorlessa heitorlessa merged commit f7a6794 into aws-powertools:develop Nov 3, 2020
@michaelbrewer michaelbrewer deleted the feat-data-classes-event-updates branch November 3, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants