Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): enable end-to-end test workflow #1470

Merged
merged 9 commits into from Aug 23, 2022

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Aug 23, 2022

Issue number: #1435

Summary

This PR enables our new E2E framework to run on push and manually.

It also (1) refreshes the contributing guide to include our testing definition, and (2) maintainers playbook to include more info on the E2E test structure.

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.


View rendered CONTRIBUTING.md

@heitorlessa heitorlessa requested a review from a team as a code owner August 23, 2022 13:00
@heitorlessa heitorlessa requested review from leandrodamascena and removed request for a team August 23, 2022 13:00
@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code internal Maintenance changes labels Aug 23, 2022
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 23, 2022
@heitorlessa heitorlessa marked this pull request as draft August 23, 2022 13:09
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #1470 (3531e2b) into develop (6930b42) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1470   +/-   ##
========================================
  Coverage    99.89%   99.89%           
========================================
  Files          123      123           
  Lines         5497     5498    +1     
  Branches       629      629           
========================================
+ Hits          5491     5492    +1     
  Misses           2        2           
  Partials         4        4           
Impacted Files Coverage Δ
aws_lambda_powertools/event_handler/appsync.py 100.00% <100.00%> (ø)
aws_lambda_powertools/utilities/batch/sqs.py 96.38% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rubenfonseca
Copy link
Contributor

It was a trap! I thought it was ready for review!

@heitorlessa
Copy link
Contributor Author

It was a trap! I thought it was ready for review!

HAHAHAHA almost there!

@heitorlessa heitorlessa marked this pull request as ready for review August 23, 2022 13:35
@boring-cyborg boring-cyborg bot added the tests label Aug 23, 2022
@heitorlessa
Copy link
Contributor Author

Ready to go @rubenfonseca !

@heitorlessa heitorlessa merged commit a45a792 into aws-powertools:develop Aug 23, 2022
@heitorlessa heitorlessa deleted the chore/enable-e2e branch August 23, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code internal Maintenance changes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants