chore(batch): Housekeeping for recent changes #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * base.py - `records` can't just be iterable as we reference it by `__getitem__` * base.py - logger.debugger is expecting a `%s` * docs - Typos in the docs * formatter.py - `_build_root_keys` can be a static method
Codecov Report
@@ Coverage Diff @@
## develop #157 +/- ##
============================================
+ Coverage 97.92% 100.00% +2.07%
============================================
Files 33 33
Lines 917 918 +1
Branches 77 77
============================================
+ Hits 898 918 +20
+ Misses 19 0 -19
Continue to review full report at Codecov.
|
Changes: * Make docstrings consistent * Add missing test cases (although this might be trivial)
michaelbrewer
changed the title
heitorlessa
requested changes
Sep 3, 2020
| @@ -95,7 +95,7 @@ def failure_handler(self, record: Any, exception: Exception): | |||
| "fail", exceptions args, original record | |||
| """ | |||
| entry = ("fail", exception.args, record) | |||
| logger.debug("Record processing exception: ", exception) | |||
| logger.debug("Record processing exception: %s", exception) | |||
There was a problem hiding this comment.
Could you change to f-string for consistency, please?
There was a problem hiding this comment.
@heitorlessa sure.
There was a problem hiding this comment.
@heitorlessa done.
| """ | ||
| Information about the Amazon Cognito identity that authorized the request. | ||
| """ | ||
| """Information about the Amazon Cognito identity that authorized the request.""" |
There was a problem hiding this comment.
This reminds me we need to prioritise a minter for NumPy docstrings
There was a problem hiding this comment.
@heitorlessa - sure
heitorlessa
approved these changes
Sep 3, 2020
heitorlessa
referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
Sep 11, 2020
* develop: (57 commits) chore: bump version to 1.5.0 (#158) chore(batch): Housekeeping for recent changes (#157) docs: address readability feedbacks chore: add debug logging for sqs batch processing chore: remove middlewares module, moving decorator functionality to base and sqs docs: add detail to batch processing fix: throw exception by default if messages processing fails chore: add test for sqs_batch_processor interface fix: add sqs_batch_processor as its own method docs: simplify documentation more SQS specific focus Update for sqs_batch_processor interface chore: add sqs_batch_processor decorator to simplify interface feat(parameters): transform = "auto" (#133) chore: fix typos, docstrings and type hints (#154) chore: tiny changes for readability fix: ensure debug log event has latest ctx docs: rephrase the wording to make it more clear docs: refactor example; improve docs about creating your own processor refactor: remove references to BaseProcessor. Left BasePartialProcessor docs: add newly created Slack Channel fix: update image with correct sample ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Changes:
recordscan't just be iterable as we reference it by__getitem__%s_build_root_keyscan be a static methodChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.